Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Track handles from enqueue functions in validation layer #17855

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

kswiecicki
Copy link
Contributor

On handle release, the validation layer reports event handles obtained via enqueue functions as invalid. This patch should fix this behavior.

@kswiecicki kswiecicki requested a review from a team as a code owner April 4, 2025 12:33
@kswiecicki kswiecicki requested review from pbalcer and igchor April 4, 2025 12:33
@kswiecicki kswiecicki force-pushed the val-event-handle-tracking-fix branch from 7f46f83 to 79378cf Compare April 4, 2025 12:39
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but can you please add a test?

@kswiecicki kswiecicki force-pushed the val-event-handle-tracking-fix branch from 79378cf to df3febb Compare April 7, 2025 10:48
@kswiecicki kswiecicki force-pushed the val-event-handle-tracking-fix branch from df3febb to b1e2789 Compare April 7, 2025 10:50
@kswiecicki
Copy link
Contributor Author

lgtm, but can you please add a test?

Done. I've added 3 test cases with event handles.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
On handle release, the validation layer reports event handles obtained
via enqueue functions as invalid. This patch should fix this behavior.
@kswiecicki kswiecicki requested review from igchor and removed request for igchor April 9, 2025 09:20
@kswiecicki
Copy link
Contributor Author

@intel/llvm-gatekeepers, someone merge this please.

@steffenlarsen steffenlarsen merged commit 94760db into intel:sycl Apr 9, 2025
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants